cresettings: add Confidential Compute node and per-owner limits#2208
Merged
Conversation
prashantkumar1982
changed the title
Contributor
✅ API Diff Results -
|
nadahalli
approved these changes
Jun 30, 2026
vreff
approved these changes
Jun 30, 2026
russell-stern
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Confidential Compute (San Marino framework) settings to
cresettingsso the executor's rate-limit / retry / secrets-cache configuration can be driven by the CRE limits framework instead of the job spec.New settings:
ConfidentialCompute.GlobalRate(config.Rate, global scope) — node-global request rate; wasGlobalRPS/GlobalBurstConfidentialCompute.MaxRetries(int) — wasMaxRetriesConfidentialCompute.RetryBackoff(time.Duration) — wasRetryBackoffSecondsConfidentialCompute.SecretsCacheEnabled(bool) — wasEnableSecretsCachePerOwner.ConfidentialCompute.Rate(config.Rate, owner scope) — per-workflow-owner rate; wasWorkflowOwnerRPS/WorkflowOwnerBurstDefaults exactly mirror the previous hardcoded executor defaults (
1000rps:1000, retries3, backoff2s, cachefalse), so behavior is unchanged until a deployment explicitly overrides them. Regenerateddefaults.json/defaults.tomlgolden files and updated theREADME.mdflowchart with a Confidential Compute subgraph.Context (PRIV-504)
First of two PRs migrating Confidential Compute config off the job spec into the limits framework. The consuming change lives in the
confidential-computerepo (theRealExecutor) and depends on this being released and version-bumped there. Migration is staged so nothing changes on deploy: limits become the source of truth, the existing job-spec fields remain as transitional overrides, deployments then move their tuned values into scoped settings overrides, and finally the job-spec fields are removed.These settings are node-local (rate / retry / cache) and never feed the hashed enclave request, so they carry no DON-to-DON determinism risk.