Skip to content

Add GetTransaction and GetSigningAccount to Stellar relayer API#2202

Open
Krish-vemula wants to merge 6 commits into
mainfrom
stellar-gettx-signing-v2
Open

Add GetTransaction and GetSigningAccount to Stellar relayer API#2202
Krish-vemula wants to merge 6 commits into
mainfrom
stellar-gettx-signing-v2

Conversation

@Krish-vemula

@Krish-vemula Krish-vemula commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (5)

pkg/chains/stellar.StellarClient (2)

  • GetSigningAccount — ➕ Added

  • GetTransaction — ➕ Added

pkg/types.StellarService (1)
  • GetSigningAccount — ➕ Added
pkg/types/chains/stellar.Client (2)

  • GetTransaction — ➕ Added

  • GetTransaction — ➕ Added

✅ Compatible Changes (26)

pkg/chains/stellar (11)

  • ConvertGetSigningAccountResponseFromProto — ➕ Added

  • ConvertGetSigningAccountResponseToProto — ➕ Added

  • ConvertGetTransactionRequestFromProto — ➕ Added

  • ConvertGetTransactionRequestToProto — ➕ Added

  • ConvertGetTransactionResponseFromProto — ➕ Added

  • ConvertGetTransactionResponseToProto — ➕ Added

  • GetSigningAccountResponse — ➕ Added

  • GetTransactionRequest — ➕ Added

  • GetTransactionResponse — ➕ Added

  • Stellar_GetSigningAccount_FullMethodName — ➕ Added

  • Stellar_GetTransaction_FullMethodName — ➕ Added

pkg/chains/stellar.StellarServer (2)

  • GetSigningAccount — ➕ Added

  • GetTransaction — ➕ Added

pkg/chains/stellar.UnimplementedStellarServer (2)

  • GetSigningAccount — ➕ Added

  • GetTransaction — ➕ Added

pkg/types.(*UnimplementedStellarService) (2)

  • GetSigningAccount — ➕ Added

  • GetTransaction — ➕ Added

pkg/types/chains/stellar (3)

  • GetSigningAccountResponse — ➕ Added

  • GetTransactionRequest — ➕ Added

  • GetTransactionResponse — ➕ Added

pkg/types/mocks (2)

  • StellarService_GetSigningAccount_Call — ➕ Added

  • StellarService_GetTransaction_Call — ➕ Added

pkg/types/mocks.(*StellarService) (2)

  • GetSigningAccount — ➕ Added

  • GetTransaction — ➕ Added

pkg/types/mocks.(*StellarService_Expecter) (2)

  • GetSigningAccount — ➕ Added

  • GetTransaction — ➕ Added

📄 View full apidiff report

@Krish-vemula
Regenerate stellar.pb.go with protoc-gen-go v1.36.11
0f5e9de
@Krish-vemula
Add unit tests for Stellar GetTransaction and GetSigningAccount relay…
d77a774 
…er methods

Cover request validation, RPC error handling, not-found paths, and keystore-backed signing account resolution.
@Krish-vemula
Add relayerset and UnimplementedStellarService tests for GetTransacti…
7af77ee 
…on and GetSigningAccount

Cover the relayerset gRPC routing layer and restore stellar unimplemented stub tests so SonarQube new-code coverage includes the APIs added in this branch.
@Krish-vemula Krish-vemula marked this pull request as ready for review June 26, 2026 15:08
@Krish-vemula Krish-vemula requested review from a team as code owners June 26, 2026 15:08
@Krish-vemula Krish-vemula requested a review from ilija42 June 26, 2026 15:09
ilija42
ilija42 reviewed Jun 26, 2026
View reviewed changes

@ilija42 ilija42 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why set the transmitter in the capability code instead of just letting the chain service handle it?

@Krish-vemula Krish-vemula requested a review from ilija42 June 28, 2026 12:23
ilija42
ilija42 approved these changes Jun 29, 2026
View reviewed changes

@ilija42 ilija42 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but lets spend a minute to think about what are the odds of the signing account retrieved for the args being different from the actual one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilija42 ilija42 ilija42 approved these changes
@silaslenihan silaslenihan Awaiting requested review from silaslenihan
@george-dorin george-dorin Awaiting requested review from george-dorin

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krish-vemula @ilija42