CRE-6741 (refactor) Clean up unused flags - #790
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested review from
agparadiso,
dhaidashenko and
george-dorin
September 22, 2026 14:22
Contributor
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
bolekk
requested changes
Sep 22, 2026
| ReceivedAt: timestamppb.New(req.ReceivedAt), | ||
| Input: req.Input, | ||
| RemoveLibUseInFailureMessageFormattingFlag: true, | ||
| UpdateErrorHandlingFlag: true, |
Contributor
There was a problem hiding this comment.
We can't do it this way. Once we upgrade the first node, all others will automatically revert because they will still have the old logic in Outcome. We need to remove the outcome logic first without touching observations.
bolekk
reviewed
Sep 22, 2026
Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com>
bolekk
approved these changes
Sep 22, 2026
bolekk
previously approved these changes
Sep 22, 2026
bolekk
enabled auto-merge
September 22, 2026 15:56
jmank88
reviewed
Sep 22, 2026
Co-authored-by: Jordan Krage <jmank88@gmail.com>
jmank88
approved these changes
Sep 22, 2026
|
bolekk
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flags date from April/May and have since long been deployed. This removes the flags in anticipation of adding a new flag which fixes the quorum we use for median.