all sol + evm family writer nodes return gas fee - #787
Merged
Merged
Conversation
patrickhuie19
marked this pull request as ready for review
September 21, 2026 19:22
product-security-plaid-production
Bot
requested review from
pavel-raykov,
russell-stern and
yashnevatia
September 21, 2026 19:22
silaslenihan
previously approved these changes
Sep 21, 2026
| return wr.executeWriteReport(ctx, request, metadata, telemetryContext) | ||
| } | ||
|
|
||
| func (e *WriteReport) getFee(ctx context.Context, txIdempotencyKey string) (*big.Int, error) { |
Contributor
There was a problem hiding this comment.
@ilija42, do you recall what the original motivation for fetching fees from TXM was?
| // A fee lookup failure is surfaced via monitoring and yields empty metadata instead of | ||
| // failing the reply. | ||
| func (wr *WriteReport) meteringFromTxSignature(ctx context.Context, telemetryContext monitoring.TelemetryContext, request *solcap.WriteReportRequest, sig solana.Signature) capabilities.ResponseMetadata { | ||
| feeInLamports, err := wr.getFee(ctx, sig) |
Contributor
There was a problem hiding this comment.
should have retry logic
Unheilbar
previously approved these changes
Sep 22, 2026
patrickhuie19
dismissed stale reviews from Unheilbar and silaslenihan
via
September 22, 2026 16:43
a7f004e
patrickhuie19
requested review from
Unheilbar,
dhaidashenko and
silaslenihan
September 22, 2026 16:44
|
dhaidashenko
approved these changes
Sep 22, 2026
Unheilbar
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.