jose: reject an empty x5cInsecure chain instead of indexing past it - #1129
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
decodeCerts returns an empty slice and no error for an empty list, so a token whose x5cInsecure header is [] produced a zero-length chain. ParseX5cInsecure then took chain[0] and panicked with index out of range. The header is read off a token supplied by the client, so the input is not under the caller's control. Reject the empty chain in GetX5cInsecureHeader, which is exported and whose other callers also expect a leaf. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decodeCertsreturns an empty slice and a nil error when handed an empty list, so a token whosex5cInsecureheader is[]yields a zero-length chain.ParseX5cInsecurethen reaches for the leaf:which gives
panic: runtime error: index out of range [0] with length 0. The header comes off a token supplied by the client, so the shape of that list is not something the caller chose.The check goes in
GetX5cInsecureHeaderrather than at the index. It is exported, and a caller that asks for an x5cInsecure chain wants a leaf, so an empty chain is not a useful result for any of them.Verification: a new test in
josesigns a token whosex5cInsecureheader is an empty list and parses it. It panics on main, and now returnsssh check-host token x5cInsecure header is empty.go test ./...passes, 39 packages.