Skip to content

ci: build linked packages before generating docs for releases#2570

Merged
zimeg merged 1 commit into
mainfrom
zimeg-ci-build-changelog
Apr 30, 2026
Merged

ci: build linked packages before generating docs for releases#2570
zimeg merged 1 commit into
mainfrom
zimeg-ci-build-changelog

Conversation

@zimeg
Copy link
Copy Markdown
Member

@zimeg zimeg commented Apr 30, 2026

Summary

This PR builds linked packages before generating docs for releases. For #2569. Follows #2559. 📚

Fixes an issue where types were assumed to be "any" between packages!

Notes

We mirror this step before the actual publish in following steps:

- name: Build packages
run: |
# Build base dependencies
npm run build --workspace=@slack/logger
npm run build --workspace=@slack/types
# Build packages requiring base dependencies
npm run build --workspace=@slack/web-api
npm run build --workspace=@slack/webhook
# Build packages that depend on the Web API
npm run build --workspace=@slack/oauth
npm run build --workspace=@slack/rtm-api
npm run build --workspace=@slack/socket-mode

Requirements

@zimeg zimeg self-assigned this Apr 30, 2026
@zimeg zimeg requested a review from a team as a code owner April 30, 2026 00:29
@zimeg zimeg added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only area:typescript issues that specifically impact using the package from typescript projects github_actions Pull requests that update GitHub Actions code labels Apr 30, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

⚠️ No Changeset found

Latest commit: 971da3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zimeg
Copy link
Copy Markdown
Member Author

zimeg commented Apr 30, 2026

🗣️ Fast merging to confirm this is a correct fix!

@zimeg zimeg merged commit 494703f into main Apr 30, 2026
9 of 10 checks passed
@zimeg zimeg deleted the zimeg-ci-build-changelog branch April 30, 2026 00:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.38%. Comparing base (5395b0c) to head (971da3c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2570   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          62       62           
  Lines       10256    10256           
  Branches      415      415           
=======================================
  Hits         8962     8962           
  Misses       1273     1273           
  Partials       21       21           
Flag Coverage Δ
cli-hooks 87.38% <ø> (ø)
cli-test 87.38% <ø> (ø)
logger 87.38% <ø> (ø)
oauth 87.38% <ø> (ø)
socket-mode 87.38% <ø> (ø)
web-api 87.38% <ø> (ø)
webhook 87.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:typescript issues that specifically impact using the package from typescript projects bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant