Navigation safe area subcompose refactor - #494
Conversation
This eliminates the need to use `onGloballyPositioned` to measure the app bar, eliminating layout shift.
|
We have a related production reproduction in OurApp.
|
This eliminates the need to use `onGloballyPositioned` to measure the app bar, eliminating layout shift.
|
We have a related production reproduction in OurApp.
|
WindowInsetsinstead of a_safeAreaenvironment value #493This is currently a draft PR partly because I'm not yet sure there are enough tests, and also because I'm not sure this is the right direction.
This PR uses
SubcomposeLayoutto layout theTopAppBarand the body content of theNavigationStack, mirroring the implementation of ComposeScaffold(see their implementation.)This eliminates the need to use
onGloballyPositionedto measure the app bar, eliminating layout shift.Skip Pull Request Checklist:
swift test(Not required)
Cursor generated the core of this PR. I manually tested it with the Showcase app in the SafeAreaPlayground, but I'm not confident I've done enough manual testing; I don't want to invest a lot of energy into it unless we agree that this is something like the right approach.