Feature: Auto-populate selectivity function parameter columns in gear_params#431
Open
gustavdelius wants to merge 1 commit into
Open
Feature: Auto-populate selectivity function parameter columns in gear_params#431gustavdelius wants to merge 1 commit into
gustavdelius wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements auto-population of selectivity function parameter columns in the
gear_paramsS3 class.Summary of Changes
Updated
check_gear_paramsto automatically check the arguments of functions stored insel_funcand add any missing arguments as columns in thegear_paramsobject withNAvalues.Since the columns are now automatically created,
validGearParams's copy-over and default-filling flow works out-of-the-box when assigning thegear_paramsobject back to theMizerParamsobject.Added a new unit test block in
tests/testthat/test-setFishing.Rto verify that settingsel_func <- "sigmoid_length"dynamically createsl25andl50columns.Adapted
tests/testthat/test-calc-selectivity.Rto strip the subclass prior to parameter deletion testing.