Repository navigation
[OMEGA-431] Skills/Workflows persistence - #407
Draft
paul-v-snet wants to merge 7 commits into
Draft
paul-v-snet wants to merge 7 commits into
paul-v-snet wants to merge 7 commits into
Conversation
…31-433-custom-skills
…th overrides for built-in skills
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main idea of these changes is to split skills/workflows into two types:
The core skills still remain in
plugins/workflow/instructions, and the custom skills are now located inmemory/workflow/skills.The main reason for keeping the core skills in the instructions directory is that if we move them to the
memorydirectory, they will also be included in theomega-memoryvolume. Because of this, they won't be updated automatically on the user's side, since they already exist in the volume and will be skipped.So, to ensure that core skill updates are always applied on the user's side, I decided to keep them outside
memory.In addition, I defined the "workflow memory directory" as a
spacethat will serve to store workflows/skills metadata (results, some intermediate data, and so on). This will be located inmemory/workflow/spaceand will also be preserved in theomega-memoryvolume.Regarding the
memory exportmechanism: I opened a draft PR in theimport-knowledge-packagerepo that introduces a newskillscomponent in thememory_portabilitymodule, which will now work not only with history and LTM but also with the custom skills introduced here.According to these changes, I also had to replace the
bothoption with thealloption because now we have three components instead of two, sobothwould be confusing here.I also implemented all the necessary changes on the core side, so once
import-kbversion0.2.6is released, both implementations will work together and support thehistory,ltm,skills, andalloptions.How Has This Been Tested?
Tested locally with a live agent: added skills persisted after container restarts and image rebuilds.
Also, all
memory-exportfeatures work fine withimport-kbversion0.2.6.Checklist