Remove completion trigger windows restriction#981
Open
wk9874 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove completion trigger windows restriction
📝 Summary
If you try to use completion trigger on Windows, it will throw you back an error saying the feature is disabled due to function pickling restrictions. This must be a hangover from a previous implementation, since there is now no pickling involved in the executor. Removing this guard to see if it works
🔍 Diagnosis
Found when developing new tutorials on building connectors
🔄 Changes
Remove guard, remove unix marks from tests
✔️ Checklist