Skip to content

fix(ci): republish the CLI when its workflow or bundled workspace code changes - #7821

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/cli-publish-trigger
Sep 14, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/cli-publish-trigger

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The CLI publish only triggers on changes under packages/sim-cli, so a change that affects the shipped package from elsewhere never republishes it
  • A change to the publish workflow itself now republishes (same as helm.yml does for its own workflow), so a build or publish fix actually ships
  • packages/utils now triggers too: the CLI bundles @sim/utils into dist, so a change there changes what ships (same as publish-sim-setup)
  • bun.lock is deliberately left out: the CLI's third-party dependencies are declared in its own package.json, which is already covered, and lockfile churn from other workspaces would publish a new CLI version on most merges
  • Merging this republishes the CLI, so the telemetry build fix that already landed reaches npm

Type of Change

  • Bug fix

Testing

  • Reproduced the publish's two builds locally: the published bundle carries the reporting token with the current job-level env, and none without it; the currently published versions carry none
  • Version bumps resolve from what's already on npm, so a run with no package code change still publishes a unique version
  • bun run lint, check:audits, docs-manifest:check, and actionlint pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 14, 2026 9:31pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the added filters cover the intended publish inputs without changing build or release execution.

Summary

This PR broadens the CLI publishing workflow's push filters so npm releases are also triggered when the workflow itself or bundled packages/utils code changes.

  • Adds packages/utils/**, covering the CLI's only bundled workspace dependency.
  • Adds the publishing workflow path, allowing build and release fixes to trigger their own publication.
  • Leaves the existing branch-specific versioning and publication behavior unchanged.

Reviews (1) · Last reviewed commit: "fix(ci): republish the CLI when its work..."

@waleedlatif1
waleedlatif1 merged commit c3ccda5 into staging Sep 14, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/cli-publish-trigger branch September 14, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant