Skip to content

improvement(network): consolidate validated HTTP transports - #7795

Open
waleedlatif1 wants to merge 2 commits into
stagingfrom
codex/http-transport-foundation
Open

improvement(network): consolidate validated HTTP transports#7795
waleedlatif1 wants to merge 2 commits into
stagingfrom
codex/http-transport-foundation

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Reuse the validated HTTP helpers for webhook provider requests and preserve deployment proxy settings, original Host/SNI, and destination pinning on Node and Bun.
  • Preserve streaming, multipart requests, decompression limits, cancellation, and configured private model endpoints. Fix nested TLS sockets, default CONNECT ports and Request body replay across redirects.
  • Document proxy behavior and keep organization routing in the dependent feature PR.

Type of Change

  • Improvement

Testing

  • 2,208 focused HTTP, webhook, proxy and MCP tests passed after the redirect replay fix. Coverage includes real Linux Bun sockets, default ports, body-preserving redirects and explicit body overrides.
  • App typecheck, lint, all 46 repository audits, block registry and docs manifest checks passed.
  • Full application regression: 50,935 tests passed; 185 skipped. CI build remains a release gate.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 12, 2026 10:13am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously reported redirect replay defect is fixed and its thread has been resolved, with no established new failures or rule violations.

Summary

  • Adds validated direct and environment-proxy dispatchers for Node and Bun.
  • Migrates webhook providers and MCP transport paths onto shared HTTP helpers.
  • Extends self-hosted egress profiles for explicitly configured private model endpoints.
  • Fixes replay of inherited Request bodies across body-preserving redirects.
  • Adds focused proxy, TLS, redirect, response-limit, framing, webhook, and egress tests.
  • Documents environment-proxy behavior and self-hosted SSRF allowances.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Caller[Webhook, MCP, or model caller] --> Guard[Validated fetch adapter]
  Guard --> Policy[SSRF and egress policy]
  Policy --> Resolve[Resolve and pin destination IP]
  Resolve --> Route{Proxy configured?}
  Route -->|No or NO_PROXY| Direct[Direct pinned connection]
  Route -->|Environment proxy| Proxy[Validated proxy connection]
  Proxy --> Tunnel[Numeric CONNECT tunnel]
  Tunnel --> TLS[Original host and TLS identity]
  Direct --> Destination[Approved destination]
  TLS --> Destination
Loading

Reviews (2) · Last reviewed commit: "fix(network): replay Request bodies acro..."

Comment thread apps/sim/lib/core/security/input-validation.server.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant