Skip to content

fix(sidebar): unify navigation menus and stabilize hydration - #7791

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/sidebar-menu-scopes
Sep 12, 2026
Merged

fix(sidebar): unify navigation menus and stabilize hydration#7791
waleedlatif1 merged 2 commits into
stagingfrom
codex/sidebar-menu-scopes

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Share profile/help menu controls, keep the organization profile menu to Settings and Sign out, and add a guarded return from workspaces to the organization.
  • Use consistent workspace-switcher row sizing, preserve search focus, and stabilize pin actions and collapsed flyouts.
  • Let the organization logo fill its click target and dim on hover/focus using its existing rounded corners.
  • Render prefetched sidebar identity immediately and use the hydrated profile for menu visibility, removing avoidable loading flashes.

Type of Change

  • Bug fix

Testing

  • 541 sidebar, navigation, sign-out, billing-visibility, and EMCN tests passed, including server-rendered expanded/collapsed header coverage.
  • App and EMCN type checks, cleanup, lint, all 46 audits, block-registry validation, and generated-artifact checks passed.
  • Manually checked organization/workspace navigation, settings shortcuts, keyboard switching, filtered lists, and expanded/collapsed reloads.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 12, 2026 12:07am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR is not yet safe to merge because large retained RSS feeds can eventually trigger duplicate workflow deliveries, and the explicit import-order requirement must also be satisfied.

Findings

  1. P2 Import Order Violates Requirement

Summary

  • Reuses shared profile and help menus across sidebar surfaces.
  • Refines organization invitations, workspace actions, guarded navigation, and sign-out behavior.
  • Changes RSS delivery filtering from the last poll boundary to the subscription boundary.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Fetch RSS feed] --> B{GUID tracked?}
  B -->|Yes| C[Skip item]
  B -->|No| D{Published after subscription?}
  D -->|No| C
  D -->|Yes| E[Select among newest 25]
  E --> F[Run idempotent processing]
  F --> G[Prepend GUID to tracked history]
  G --> H[Retain only 500 GUIDs]
  H --> I[Evicted GUID can become eligible again]
Loading

Reviews (2) · Last reviewed commit: "fix(sidebar): simplify organization prof..."

@waleedlatif1
waleedlatif1 force-pushed the codex/sidebar-menu-scopes branch from bf49c0b to bf78626 Compare September 12, 2026 00:05
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 1d4c004 into staging Sep 12, 2026
33 of 34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/sidebar-menu-scopes branch September 12, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant