Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
j15z
force-pushed
the
fix/compact-mode-switches
branch
from
September 6, 2026 01:13
26af09f to
f8470a4
Compare
Restore the two-choice icon switch with smaller geometry and consistent label-row spacing. Use it for canonical subblocks, Start file inputs, boolean assignments, and knowledge connector fields. Keep connector radio controls outside field labels and preserve disabled and selected-state behavior.
j15z
force-pushed
the
fix/compact-mode-switches
branch
from
September 14, 2026 20:12
ea2a0a8 to
2d6799d
Compare
10 tasks
Collaborator
Author
|
Superseded by #7825. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the ⇄ arrow toggle with a compact two-choice
IconSwitchwherever an input flips between two modes, so the active mode is visible directly instead of implied by the arrow's tint. This restores #7527, which was reverted in #7550, with smaller geometry that keeps the existing label-to-input spacing.Where it applies:
CanonicalModeToggleIconSwitchis a new emcn component: two 16px inset squares in a 1px-padded frame with concentric corner radii. It is built on native radios, so keyboard navigation and mutual exclusion come from the browser, and each option's label shows as a tooltip.On connector fields the switch sits in
ChipModalField'stitleActionsslot (added on staging in #7761), outside the<label>, so clicking the field title doesn't change the mode. It is disabled during submission, and its accessible name uses the admin-mode title when one applies. The decorative HTTP method icon is unchanged.Related: #7527, #7550
Type of Change
Testing
IconSwitch,ChipModal, the connector config fields and hook, subblocks, and Start file inputs.apps/simandpackages/emcntype checks pass. Biome andbun run check:api-validationpass.titleActionsslot instead of adding a separatetitleAdornmentprop.Reviewers: please check the switch's alignment in the connector modal's title row, which now uses staging's
flex-wrap gap-2layout.Checklist
Screenshots/Videos
Pending visual review.
🤖 Generated with Claude Code