improvement(self-host): simplify capability setup configuration - #6230
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryHigh Risk Overview Runtime capability model ties visible integration blocks to
CI and authoring: Reviewed by Cursor Bugbot for commit babb8c0. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR centralizes self-hosted deployment capability definitions and separates runtime configuration from setup presentation.
Confidence Score: 5/5The PR appears safe to merge because no eligible blocking follow-up finding or outstanding prior finding remains. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/core/config/env-capabilities.ts | Introduces the central runtime model for inspecting and requiring deployment capabilities and OAuth client configuration. |
| scripts/setup/capability-config.ts | Separates setup field presentation from runtime capability definitions with exhaustive drift checking. |
| scripts/setup/capability-setup.ts | Implements generic provider setup using the centralized capability and setup-field catalogs. |
| apps/sim/lib/integrations/availability.ts | Resolves integration deployment availability from generated OAuth and service-account metadata. |
| apps/sim/lib/integrations/availability.server.ts | Provides cached server bindings for integration and OAuth-service deployment availability. |
| apps/sim/lib/integrations/service-account-metadata.ts | Defines service-account provider projections and their deployment requirements. |
| apps/sim/lib/core/config/redis.ts | Routes Redis configuration through the centralized cache capability. |
| scripts/check-integration-catalog.ts | Adds drift validation between executable integration definitions and the committed client-safe catalog. |
| apps/sim/lib/core/config/env-capabilities.test.ts | Covers provider selection, partial and invalid configurations, defaults, and OAuth aliases. |
| scripts/setup/capability-config.test.ts | Verifies setup metadata remains exhaustive and aligned with runtime capability fields. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Env[Environment and Helm values] --> Cap[Runtime capability definitions]
Setup[Self-host setup CLI] --> SetupMap[Setup field presentation]
SetupMap -. drift checks .-> Cap
Cap --> Runtime[Runtime resource consumers]
Cap --> OAuth[OAuth client capability resolution]
OAuth --> Catalog[Generated integration catalog]
Catalog --> Availability[Integration availability]
Availability --> UI[Workspace UI]
Availability --> API[API and OAuth tooling]
Availability --> Copilot[Copilot integration tools]
Runtime --> Resources[Cache, storage, jobs, email, sandbox, OCR]
Reviews (9): Last reviewed commit: "fix(integrations): preserve connect deep..." | Re-trigger Greptile
|
@cursor review |
|
@cursor review |
ce77755 to
662cd15
Compare
662cd15 to
a3d7f63
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a3d7f63. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1e9a71f. Configure here.
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 64736a0. Configure here.
# Conflicts: # apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx # apps/sim/lib/copilot/chat/process-contents.ts
|
@cursor review |
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit babb8c0. Configure here.
Summary
Type of Change
Testing
bun run test:setupbun run type-checkbun run lintChecklist