Skip to content

refactor(knowledge): make lib/knowledge/orchestration the single implementation #6154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheodoreSpeaks merged 2 commits into from
Aug 1, 2026
Merged

refactor(knowledge): make lib/knowledge/orchestration the single implementation #6154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc451af
refactor(knowledge): make lib/knowledge/orchestration the single impl…
TheodoreSpeaks Aug 1, 2026
1ba0215
fix(knowledge): make connector create atomic and stop flattening fail…
TheodoreSpeaks Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/docs/openapi-v2-knowledge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,9 +709,6 @@
"404": {
"$ref": "#/components/responses/NotFound"
},
"409": {
"$ref": "#/components/responses/Conflict"
},
"413": {
"description": "The uploaded file exceeds the 100 MB limit, or the workspace storage limit has been reached.",
"content": {
Expand Down
9 changes: 7 additions & 2 deletions apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,10 @@ describe('Knowledge Connector By ID API Route', () => {
success: true,
userId: 'user-1',
})
mockCheckWriteAccess.mockResolvedValue({ hasAccess: true })
mockCheckWriteAccess.mockResolvedValue({
hasAccess: true,
knowledgeBase: { workspaceId: 'ws-1', name: 'Test KB' },
})
dbChainMockFns.limit.mockResolvedValueOnce([])

const req = createMockRequest('PATCH', { sourceConfig: { project: 'NEW' } })
Expand All @@ -174,7 +177,8 @@ describe('Knowledge Connector By ID API Route', () => {
mockHasWorkspaceLiveSyncAccess.mockResolvedValue(true)

const updatedConnector = { id: 'conn-456', status: 'paused', syncIntervalMinutes: 5 }
dbChainMockFns.limit.mockResolvedValueOnce([updatedConnector])
dbChainMockFns.limit.mockResolvedValueOnce([{ id: 'conn-456', connectorType: 'jira' }])
dbChainMockFns.returning.mockResolvedValueOnce([updatedConnector])

const req = createMockRequest('PATCH', { status: 'paused', syncIntervalMinutes: 5 })
const response = await PATCH(req, { params: mockParams })
Expand All @@ -196,6 +200,7 @@ describe('Knowledge Connector By ID API Route', () => {
knowledgeBase: { workspaceId: 'ws-free', name: 'Free KB' },
})
mockHasWorkspaceLiveSyncAccess.mockResolvedValue(false)
dbChainMockFns.limit.mockResolvedValueOnce([{ id: 'conn-456', connectorType: 'jira' }])

const req = createMockRequest('PATCH', { syncIntervalMinutes: 5 })
const response = await PATCH(req, { params: mockParams })
Expand Down
Loading
Loading