chore(deps): vendor the free-email domain list and drop unused packages - #6032
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Also removes Reviewed by Cursor Bugbot for commit 69feafe. Configure here. |
Greptile SummaryVendors the free-email domain list in-repo and removes unused packages from
Confidence Score: 5/5This PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/messaging/email/free-email.ts | Switches free-domain lookup to a local JSON import and documents vendoring rationale plus the intentional upstream split. |
| apps/sim/lib/messaging/email/free-email-domains.json | Adds ~4.8k unique lowercase free-email domains including the four split providers. |
| apps/sim/lib/messaging/email/free-email.test.ts | Covers fused-entry providers and asserts no unexpected concatenated domain entries remain. |
| apps/sim/package.json | Removes free-email-domains, tailwind-merge, and autoprefixer from apps/sim dependencies. |
Reviews (2): Last reviewed commit: "fix(email): split two fused domain entri..." | Re-trigger Greptile
- vendor free-email-domains: its postinstall downloads a CDN CSV and overwrites its own domains.json, so the lockfile hash covers the tarball but not the installed data - drop tailwind-merge and autoprefixer from apps/sim, which imports neither (emcn and docs declare their own tailwind-merge; postcss.config loads only tailwindcss)
Upstream joins mail2moldova.com/mail2molly.com and smileyface.com/smithemail.net into one entry each, a CSV line-join artifact that made all four read as work addresses. Splitting them keeps the list sorted and adds a guard against a naive refresh.
054455a to
69feafe
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 69feafe. Configure here.
Summary
Split out of #6013. Low-risk dependency hygiene, independent of the security work in #6030.
free-email-domains. Itspostinstalldownloads a CDN CSV and overwrites its owndomains.json, so the lockfile hash covers the tarball but not the data actually installed — the list could change under a pinned version. Now a checked-in JSON (4,779 unique lowercase entries) with a TSDoc note on refreshing it from the MIT upstream.tailwind-mergeandautoprefixerfromapps/sim. Neither is used here:apps/simhas notailwind-mergeimport (it reaches it through@sim/emcn'scn(), and bothpackages/emcnandapps/docsdeclare their own), andpostcss.config.mjsloads onlytailwindcss.Type of Change
Testing
tscclean; 97 tests pass across the email modules, covering free-provider classification, work domains, case-insensitivity and malformed input against the vendored list.Checklist