fix(web+server): protect encrypted vault dirs from recursive delete#14
Open
Mingholy wants to merge 3 commits into
Open
fix(web+server): protect encrypted vault dirs from recursive delete#14Mingholy wants to merge 3 commits into
Mingholy wants to merge 3 commits into
Conversation
- isSecretsFolder: match server logic by including `.loopat/vaults` itself (not just children), so UI and server agree on what's protected - HTTP 400 for delete validation errors (was 500, triggering false 5xx alerts) - FileTree.tsx: update getContextActions signature to match Tree.tsx 2-arg form - Accurate TOCTOU comment: UI emptiness check is a stale-state hint, server rmdir is the authoritative guard Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rm -rffor all directories — an encrypted vault subtree could be wiped by a single API callpersonalvault under.loopat/vaults/) now usermdir(non-recursive) — only empty dirs succeed; non-empty raisesENOTEMPTYTest plan
.loopat/vaults/default/→ no Delete option🤖 Generated with Claude Code