Repository navigation
Require current script version in SRI header validation - #123
Merged
Merged
Conversation
User requested verifying unresolved CodeRabbit feedback with separate minimal PRs. Require the discovered SRI version to match latest.js so an obsolete version cannot make deployment validation pass. Refs #107
Claude review checkpointReviewed commit |
|
SDLC label: |
adriaandotcom
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #107. Targets
v12for #40; independent of #122.deployment header check discover newest SRI directory + require its version to match latest.js check every manifest headerUser steering: verify unresolved CodeRabbit findings and keep each change in its own small PR. Keep the existing missing-directory check and reject an older SRI directory when the latest script declares a newer version.
Evidence
dist/v12while leavingdist/v11makes the existing deployment suite pass without checking v12.SRI directory version must match dist/latest/latest.js. Restoring v12 passes all 15 deployment tests.Security implications
No collection changes. This strengthens the existing deployment validation against checking an obsolete SRI version.
Merge Danger
Door: two-way
Blast Radius: tests
Checklist
Summary by CodeRabbit