Repository navigation
Count Cloudflare challenge arrivals as unique - #112
Conversation
Requested in the compatibility review: avoid path false positives and inspect raw query-only markers. Reuse the referrer helper without sending raw query values or adding bytes to light builds. Refs #107
Documentation update
|
Claude review checkpointReviewed commit |
|
SDLC label: |
|
In response to #112 (comment) and #112 (comment), superseding #112 (comment): I corrected the pending docs patch to match 14b75fc and the owner's simplification in #112 (comment). Cloudflare referrers containing The revised four-page patch applies cleanly to current docs/master and passes formatting checks. It remains local pending the existing request for approval of a supporting docs PR, with publication dependent on this change and the v12 release. |
Requested: make issue #107 mergeable while preserving manual-query overrides, browser-query fallback, and existing filtering. Resolve the older Cloudflare branch against current v12 source and regenerate its bundles, preserving inline events and the merged phone-click fix. All 45 unit tests and 24 additional query payload checks pass. Refs #107
User requested correcting PR #112 to match issue #48. Challenge query parameter names now allow the first tracked arrival to be unique, including same-site referrers. Reloads, history navigation, and later manual or SPA pageviews remain non-unique. Keep challenge tokens out of payloads, preserve current v12 changes, and regenerate distributions. Validated with 53 offline unit tests and minified payload checks.
Documentation update
|
User asked to replace the parameter-name regex with a literal ?__cf_ check, omit the extra same-URL guard, and merge current v12 into #112. Preserve the latest modified-click, namespace, manual-query, and phone-click fixes. Rebuild matching tracker bundles while retaining unrelated pinned auto-events artifacts. All 53 unit tests, 33 payload checks, changed JavaScript formatting, and diff checks pass. Manual-query overrides and location.search fallback remain intact. Refs #107
User requested a literal ?__cf_ check without the extra same-URL guard and asked to merge v12 into #112. Include v12 at 58f6679, retaining its modified-click, namespace, manual-pageview, and phone-click fixes. Use the reviewed, broker-pushed tree with source, tests, and matching distributions. All 53 unit tests and 33 payload checks pass. Refs #107
Documentation update
|
User requested a simple marker check and current v12 merge. Address review by accepting both ?__cf_ and appended &__cf_ with the short /[?&]__cf_/ expression, retaining the requested broad matching and omitting the declined same-URL guard. Update the existing regression and matching bundles. All 53 unit tests and 36 payload checks pass. Current v12 remains included. Refs #107
Targets
v12(#40). Merge intov12before releasing #40 tomain.Summary
Fixes #107 and implements the Cloudflare arrival behavior in #48.
Use the owner's requested simple marker check on the raw referrer:
This replaces the anchored parameter-name expression with a broad marker-presence check. It accepts the marker at the start of the query or appended after existing campaign parameters. The extra same-URL guard was explicitly declined and is omitted. Existing reload/history and later-pageview handling remain in place. Referrer overrides keep working, and outgoing referrers remain stripped of query strings.
Merged current
v12at58f6679, including the modified-click fix from #78 and the previously merged manual-pageview, namespace, and phone-click fixes. Source, regression tests, and matching generated bundles are included together. Unrelated pinned auto-events artifacts and older versions are preserved.Security implications
Testing
git diff --checkpasses.v12, excluding headers:latest.js+21 minified bytes / +16 gzip bytes at level 9. Light code is unchanged.mainwas refreshed through the signed broker and is included. Remote CI is tracked separately from local validation.Merge Danger
Door: two-way.
Blast Radius: analytics. Challenge arrivals can contribute to unique visitor counts as requested; pageview totals and event names are unchanged.
Checklist