Repository navigation
Require full unique indexes for lookup tables - #915
Open
workstonedai-collab wants to merge 1 commit into
Open
workstonedai-collab wants to merge 1 commit into
workstonedai-collab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #914.
Problem
Table.lookup()checked only whether an index covered the lookup columns. A non-unique index could therefore be mistaken for the required uniqueness constraint, and a partial unique index could be treated as equivalent to a full unique index. This could allow duplicate lookup rows.Behavior
lookup()from creating the required full unique index.lookup()reuses an existing full unique index on exactly the lookup columns, or creates one when needed.sqlite3.IntegrityErrorbefore any rows are changed.This change is limited to
Table.lookup()unique-index detection and creation. It makes no broad performance or indexing claims and is independent of #913; both are based on the same upstream commit.Validation
Validation was run by Codex:
Implementation and tests: MiniMax. Review and validation: Codex.
📚 Documentation preview 📚: https://sqlite-utils--915.org.readthedocs.build/en/915/