Fix convert --dry-run using bracket quoting instead of quote_identifier() - #830
Open
ikatyal2110 wants to merge 1 commit into
Open
Fix convert --dry-run using bracket quoting instead of quote_identifier()#830ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dry-run preview in the
convertcommand built its SQL using Pythonstr.format()with[{column}]bracket quoting, which produces invalid SQL when the column or table name contains a]character. This replaces the bracket quoting withquote_identifier(), consistent with the rest of the codebase. Fixes #829.Generated by Claude Code
📚 Documentation preview 📚: https://sqlite-utils--830.org.readthedocs.build/en/830/