Skip to content

Fix patch installer after ManagedVwWindow removal#909

Merged
jasonleenaylor merged 1 commit into
mainfrom
failing_tests
May 22, 2026
Merged

Fix patch installer after ManagedVwWindow removal#909
jasonleenaylor merged 1 commit into
mainfrom
failing_tests

Conversation

@johnml1135
Copy link
Copy Markdown
Contributor

@johnml1135 johnml1135 commented May 22, 2026

Summary

  • Adds ManagedVwWindow.dll, ManagedVwWindow.dll.config, and ManagedVwWindow.pdb to the existing RescuePatching placeholders.
  • Keeps the retired Linux-era shim removed while preserving the legacy patch installer component graph for the current base build.
  • Fixes the post-merge Patch Installer failure from https://github.com/sillsdev/FieldWorks/actions/runs/26286364180, where Pyro reported PYRO0305 because those base components disappeared from the update harvest.

Verification

  • Confirmed the failing CI log reported PYRO0305 for the three ManagedVwWindow components in PatchableInstaller/CreateUpdatePatch/Master/AppHarvest.wxs.
  • Ran the focused placeholder check for all three files.
  • Ran MSBuild target Setup;RescuePatching and verified all three placeholders were created as zero-byte files under Output\Release.
  • Ran Build\Agent\Remove-StaleDlls.ps1 -OutputDir "Output\Release" -RepoRoot "." -ReferenceDir "Output\Release" -ValidateOnly and it accepted the placeholders.
  • Ran CI: Commit messages locally; no gitlint errors were reported.

This change is Reviewable

Copilot AI review requested due to automatic review settings May 22, 2026 15:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes the Patch Installer’s update-harvest failure after ManagedVwWindow removal by restoring expected base-component placeholders during RescuePatching.

Changes:

  • Adds ManagedVwWindow.dll placeholder to RescuePatching removed-since-base list
  • Adds ManagedVwWindow.dll.config placeholder to RescuePatching removed-since-base list
  • Adds ManagedVwWindow.pdb placeholder to RescuePatching removed-since-base list

@github-actions
Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 0s ⏱️ -11s
4 203 tests ±0  4 132 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 212 runs  ±0  4 141 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit 4216ecd. ± Comparison against base commit 8e99077.

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 file and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on johnml1135).

@jasonleenaylor jasonleenaylor merged commit f3fb2cf into main May 22, 2026
8 of 11 checks passed
@jasonleenaylor jasonleenaylor deleted the failing_tests branch May 22, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants