Skip to content

Fix: Filter Gradle Release Notes from Deprecation Check - #13

Merged
shining-cat merged 1 commit into
mainfrom
fix/filter-gradle-banner-from-deprecation-check
Sep 11, 2026
Merged

shining-cat merged 1 commit into
mainfrom
fix/filter-gradle-banner-from-deprecation-check

Conversation

@shining-cat

Copy link
Copy Markdown
Owner

Fix False Positive in Deprecation Check

Summary

Issue #11 was a false positive. The deprecation check workflow caught Gradle 9.6.1's release notes banner, not an actual deprecation warning in our code.

Root Cause

What happened:

  • Workflow runs: grep -i "deprecat" build-output.log
  • Gradle 9.6.1 welcome banner includes:
    Here are the highlights of this release:
     - Improved Configuration Cache hit rates
     - Additional CLI rendering options
     - Important project hierarchy lookup deprecations
    
  • The grep caught line 3 of that banner
  • Workflow reported it as a deprecation warning

Why SimpleHIIT didn't hit this:

  • SimpleHIIT uses Gradle 9.5.0
  • The 9.6.1 banner text is new
  • SimpleHIIT's deprecation check passed cleanly

Solution

Added regex filter to exclude Gradle release notes bullet points:

grep -E -v '^ - .*(deprecat|Deprecat)'

This preserves real deprecation warnings while filtering banner text.

Testing

✅ Tested locally against the September 1st artifact
✅ Filter now produces zero matches (was 1 false positive)
✅ Pattern won't filter actual deprecation warnings (those don't start with -)

Verification

After merge, the next monthly sanity check will:

  • Still catch real deprecations
  • No longer create false-positive issues from Gradle banners

Closes

Closes #11

Issue #11 was a false positive - the workflow caught Gradle 9.6.1's
release notes banner mentioning "Important project hierarchy lookup
deprecations" as a highlighted topic, not an actual deprecation warning.

Root cause: SimpleHIIT (Gradle 9.5.0) didn't hit this because the
banner text is new in 9.6.1.

Solution: Added regex filter to exclude lines matching Gradle's
bullet-point format (^ - .*deprecat). This preserves real deprecation
warnings while filtering the banner.

Tested locally against the September 1st artifact - now filters cleanly.

Fixes #11

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@shining-cat
shining-cat merged commit e07e173 into main Sep 11, 2026
4 checks passed
@shining-cat
shining-cat deleted the fix/filter-gradle-banner-from-deprecation-check branch September 11, 2026 16:08
This was referenced Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Deprecation Check] 1 deprecation warning(s) detected

1 participant