Skip to content

DNM: Add OCP upgrade stage for OSP 18#22

Open
dlaw4608 wants to merge 1 commit into
mainfrom
ocp_upgrade
Open

DNM: Add OCP upgrade stage for OSP 18#22
dlaw4608 wants to merge 1 commit into
mainfrom
ocp_upgrade

Conversation

@dlaw4608

@dlaw4608 dlaw4608 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Port upgrade functionality from openshift-ir-plugin to support sequential
OCP upgrades on OSP 18. Supports versions 4.16-4.23

DNM: WIP still needs E2E test validation

@ekuris-redhat ekuris-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Daniel, the ansible-lint CI is failing with 3 violations in collection/stages/roles/upgrade/tasks/single_upgrade.yml:

1. risky-shell-pipe - line 86 (task: "Get the OCP release digest")
2. risky-shell-pipe - line 116 (task: "Wait until the upgrade starts (Progressing=True)")

Shell tasks using pipes need the pipefail option so failures in any part of the pipe are caught. Fix by prepending set -o pipefail && to the command:

- name: Get the OCP release digest
  ansible.builtin.shell:
    cmd: set -o pipefail && your_command | grep something

3. jinja[spacing] - line 161 (warning, but blocks the required production profile)

Remove the extra spaces around the outer parentheses:

- {{ ( ((finish_time | to_datetime('%Y-%m-%dT%H:%M:%S')) - (start_time | to_datetime('%Y-%m-%dT%H:%M:%S'))).total_seconds() / 60 ) | int }}
+ {{ (((finish_time | to_datetime('%Y-%m-%dT%H:%M:%S')) - (start_time | to_datetime('%Y-%m-%dT%H:%M:%S'))).total_seconds() / 60) | int }}

Once these 3 are fixed, CI should go green.

  Port upgrade functionality from openshift-ir-plugin to support sequential
  OCP upgrades on OSP 18. Supports versions 4.16-4.23, automatically builds
  upgrade paths skipping unsupported versions like 4.17.

  Includes version-specific workarounds for 4.16 consoleplugins and 4.19
  k8s API acknowledgment. Collects must-gather on failure.
Change-Id: I8c0b804cb91774fb5bb5fccf47cdb6015d46d771
Signed-off-by: Daniel Lawton <dlawton@redhat.com>

@ekuris-redhat ekuris-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants