lib/getdef.c: def_load(): Don't handle '"' specially#1675
Open
alejandro-colomar wants to merge 1 commit into
Open
lib/getdef.c: def_load(): Don't handle '"' specially#1675alejandro-colomar wants to merge 1 commit into
alejandro-colomar wants to merge 1 commit into
Conversation
That handling of '"' in login.defs(5) is undocumented, and doesn't seem very robust: name "this value"string The line above will be taken as if the value was 'this value', with the remainder completely ignored. Another weird case is: name value"string where the value is 'value'. Since this is undocumented, brittle, and most likely not used, let's remove it entirely. After all, it's entirely useless. The following entry name value string is interpreted as having a value of 'value string', as one would expect. The quotations don't provide absolutely any value (they don't serve to escape any characters) at all, and seem dangerous instead. Fixes: 45c6603 (2007-10-07; "[svn-upgrade] Integrating new upstream version, shadow (19990709)") Closes: <shadow-maint#1674> Signed-off-by: Alejandro Colomar <alx@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That handling of
"in login.defs(5) is undocumented, and doesn't seem very robust:The line above will be taken as if the value was 'this value', with the remainder completely ignored. Another weird case is:
where the value is 'value'.
Since this is undocumented, brittle, and most likely not used, let's remove it entirely. After all, it's entirely useless.
The following entry
is interpreted as having a value of 'value string', as one would expect. The quotations don't provide absolutely any value (they don't serve to escape any characters) at all, and seem dangerous instead.
Fixes: 45c6603 (2007-10-07; "[svn-upgrade] Integrating new upstream version, shadow (19990709)")
Closes: #1674