Correct the cursor reset docs - #2223
Merged
mpretty-cyro merged 1 commit intoSep 28, 2026
Merged
Conversation
The reset guard's docs overstated the bug and understated what a reset re-fetches: - An undone reset delayed history rather than losing it: cursors are per snode, so the history arrived through another snode, and was lost only in a one-snode swarm. - A clear by namespace counts as a reset of every swarm, so a swarm it didn't clear re-fetches from its previous cursor, not the beginning. - Only regular messages are deduplicated. Config messages rely on merging being repeatable, and a kick seen again is stopped only by the key generation check. - Resets and guarded writes must not be made from inside a DB transaction, since the guard's lock is held across the SQL. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2220. Docs only; no behaviour change.
Release review found that the docs on the cursor reset guard overstated the bug and understated what a reset re-fetches:
That generation check is enough because every client rekeys when it adds a member, with or without history: Android (
GroupManagerV2Impl.inviteMembersInternal), iOS (MessageSender.addGroupMembers) and Desktop (handleMemberAddedFromUI, SES3299). A member removed and later re-invited is therefore on a newer generation than the kick they fetch again.Unit suite: 311 tests, 0 failures, against the published libsession AAR, the same as CI.