Repository navigation
fix: correct inline repr - #768
Open
alejandro-vaz wants to merge 5 commits into
Open
alejandro-vaz wants to merge 5 commits into
alejandro-vaz wants to merge 5 commits into
Conversation
alejandro-vaz
marked this pull request as ready for review
October 17, 2026 15:30
Collaborator
Author
|
callgrind shows some notable improvements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR corrects the inline representation of
RawSmallVec, moving the maybeuninit to inside the array for each element, instead of meaning a full array that may be initialized or notsince out implementation does pointer arithmetic manually anyway, this does not affect the code generation of our operations