Repository navigation
feat: restore may_dangle drop support - #762
Open
Chandana5599 wants to merge 1 commit into
Open
Chandana5599 wants to merge 1 commit into
Chandana5599 wants to merge 1 commit into
Conversation
Author
|
Hi maintainers, this PR restores |
Collaborator
|
this can indeed be made simpler if we had a prepend function for the unsafe, then we would just have cfg_attrs and it'd be much simpler give me some time to think about it |
Collaborator
|
alright with #764 this should be much easier to implement it is simply a conditional everything else stays the same and we cut 50 lines of code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
may_danglesupport behind an opt-in feature flag.Dropimplementation when the feature is disabled.SmallVec#756.Testing
cargo test --features allocator-api2cargo +nightly test --features "allocator-api2 may_dangle"cargo +nightly fmt --checkgit diff --checkFixes #756