feat(api): sync OpenAPI spec from production - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty commit carrying the conventional subject release-please needs.
The regenerated SDK — carrying the webhook envelope discriminators from sentdm/sent-dm-services#1866 — is already on
main. It arrived throughSync custom-code tracking with staging, which runsstlc build --pushwith no--commit, so the commit landed as stlc's default subjectBuild SDK. release-please ignores that, and cut no version.typescript, csharp and java were regenerated by
Generate SDKs with stlcinstead, which passes the merged pipeline PR title, so they gotfeat(api): sync OpenAPI spec from productionand their release PRs opened normally.No file changes — the SDK is unchanged and already correct. This only gives release-please a
feat(api):commit so it cuts a minor release.Production only, deliberately: an empty commit cannot travel through
Promote SDKs(it compares trees), and adding one to the staging trunk as well is what forked the trunks last time. Production being ahead is the normal post-release state and the back-sync fast-forwards staging onto it.The durable fix belongs in
stlc-sync-tracking.yml, which should pass a conventional--commitmessage.