fix(envtest): default NLBTargetType to ip in suite reconciler

[bdchatham]

Summary

PR #372 introduced SEI_NLB_TARGET_TYPE with default-resolution centralised in cmd/main.go — the reconciler's NLBTargetType field is canonical, no per-reconcile fallback. The envtest suite (internal/controller/nodedeployment/envtest/suite_test.go) is a parallel "main" that constructs its own SeiNodeDeploymentReconciler and doesn't read the env var, so it landed with NLBTargetType: "".

Result: generateP2PEndpointService stamped the target-type annotation with the empty string, and TestP2PEndpointP2P_CreateWithTCP_ChildHasAddressAndServiceExists failed asserting aws-load-balancer-nlb-target-type=ip.

Fix

One-line: set NLBTargetType: nodedeploymentcontroller.DefaultNLBTargetType in the envtest suite, mirroring the cmd/main.go invariant.

Verification

make test-integration passes locally with this change.

Note on the ECR image at 6a4334e (PR #372 merge commit)

The ECR workflow built successfully despite the CI failure (separate workflow, doesn't gate on tests). The production code path is unaffected — cmd/main.go correctly defaults to ip. Only the envtest scaffolding was missing the same default. The image 6a4334e184ddbd34f183611b8824ad29559c19e3 is safe to deploy as-is.

🤖 Generated with Claude Code

[cursor]

PR Summary

Low Risk
Test-only wiring in the envtest suite; no production controller or deployment path changes.

Overview
After PR #372, SeiNodeDeploymentReconciler.NLBTargetType is set from SEI_NLB_TARGET_TYPE in cmd/main.go (default ip) with no in-reconciler fallback. The envtest suite builds its own reconciler and left NLBTargetType empty, so P2P endpoint Services got a blank aws-load-balancer-nlb-target-type annotation and integration tests expecting ip failed.

The change sets NLBTargetType to nodedeploymentcontroller.DefaultNLBTargetType in suite_test.go, aligning envtest with the production default. Runtime behavior outside tests is unchanged.

^{Reviewed by Cursor Bugbot for commit eef22f3. Bugbot is set up for automated code reviews on this repo. Configure here.}