Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## giga-1 #4211 +/- ##
==========================================
- Coverage 65.55% 65.53% -0.03%
==========================================
Files 2081 2077 -4
Lines 157460 157094 -366
==========================================
- Hits 103222 102947 -275
+ Misses 54097 54006 -91
Partials 141 141
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An EVM-only node whose FlatKV state was written before #4190 introduced the durable execution cursor holds block state at a nonzero version but no
evmonly/cursorrecord.loadEVMOnlyCursortreated a missing cursor as "nothing to resume" and returned None, soInfo()reported height 0, the giga router took the fresh-start path and calledInitChain, andseedInitialStateVersionthen refused because the store was already at height 364932. The node crash-looped withApp.InitChain(): EVM-only state is already at height 364932 before InitChain, a message that reads like a stale-genesis or re-init problem when the actual cause is a store that cannot tell where execution stopped.NewEVMOnlyApplicationnow takes the genesis initial height. A store without a cursor is still resumed throughInitChainwhen it is empty or sits exactly atinitialHeight-1, which is what a crash betweenInitChainand the first block leaves behind; at any other version it is refused at construction witherrEVMOnlyCursorMissing, which names the state height, the chain's first height, and the remedy (reset the EVM-only state directory so the node resyncs from the block store).prepareApplicationreads the genesis document to supply the height, so the same value drives both the startup check andInitChain. The pre-cursor stores on the testnet still need a one-time state reset; the change makes that failure explicit at startup instead of an ambiguous panic inside the router.