feat(rn): route plugin.json scripts through segkit#61
Merged
Conversation
…ommand Replace direct shell script calls in the React Native plugin's convenience scripts with segkit delegation. Adds `segkit metro` subcommand for metro.sh delegation. Fixes delegate.rs to use REACT_NATIVE_SCRIPTS_DIR instead of non-existent RN_SCRIPTS_DIR. Scripts updated: start:metro, stop:metro, start:android, start:ios, rn:metro:port, rn:metro:clean. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abueide
force-pushed
the
feat/segkit-rn-plugin
branch
from
db8bab5 to
15437d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates React Native plugin convenience scripts to call
segkitinstead of shell scripts directly. Addssegkit metrosubcommand and fixes the delegate script resolution env var.Changes
metro.sh,android.sh,ios.sh,rn.shcalls withsegkit metro/android/ios/rnin 6 plugin.json scriptssegkit metrosubcommand delegating tometro.shdelegate.rsto useREACT_NATIVE_SCRIPTS_DIR(the actual env var) instead ofRN_SCRIPTS_DIR(which doesn't exist)Why
Phase 1.4 of the shell-to-Rust migration. Completes the delegation layer for all three plugins. Also fixes a latent bug where
rn.shandmetro.shresolution viaSCRIPTS_DIRenv var would silently fail and fall through to PATH lookup.🤖 Generated with Claude Code