Skip to content

sslv2: implement stricter 'security' (yeah, we know) - #5197

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:sslv2-security
Sep 23, 2026
Merged

gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:sslv2-security

Conversation

@gpotter2

Copy link
Copy Markdown
Member

There's something poetic about improving the security of our SSLv2 stack.

Co-Authored-By: Clinton Thomas <1033162+KernelClint@users.noreply.github.com>
AI-Assisted: no
Comment thread scapy/layers/tls/record_sslv2.py Dismissed
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.87%. Comparing base (22d3930) to head (a113730).

Files with missing lines Patch % Lines
scapy/layers/tls/automaton_cli.py 50.00% 3 Missing ⚠️
scapy/layers/tls/automaton_srv.py 25.00% 3 Missing ⚠️
scapy/layers/tls/record_sslv2.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5197      +/-   ##
==========================================
- Coverage   80.87%   80.87%   -0.01%     
==========================================
  Files         393      393              
  Lines       98082    98097      +15     
==========================================
+ Hits        79327    79336       +9     
- Misses      18755    18761       +6     
Files with missing lines Coverage Δ
scapy/layers/tls/handshake_sslv2.py 93.58% <100.00%> (+1.60%) ⬆️
scapy/layers/tls/session.py 86.03% <100.00%> (+0.01%) ⬆️
scapy/layers/tls/automaton_cli.py 86.98% <50.00%> (-0.26%) ⬇️
scapy/layers/tls/automaton_srv.py 73.06% <25.00%> (-0.21%) ⬇️
scapy/layers/tls/record_sslv2.py 89.56% <25.00%> (-0.95%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2
gpotter2 merged commit e4742a5 into secdev:master Sep 23, 2026
41 of 43 checks passed
@gpotter2
gpotter2 deleted the sslv2-security branch September 23, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants