Skip to content

Ticketer: improve consistency when editing#5027

Open
gpotter2 wants to merge 1 commit into
secdev:masterfrom
gpotter2:other-fixes
Open

Ticketer: improve consistency when editing#5027
gpotter2 wants to merge 1 commit into
secdev:masterfrom
gpotter2:other-fixes

Conversation

@gpotter2

Copy link
Copy Markdown
Member
  • some timezones are dropped when editing a ticket, fix that
  • padding was not like on Windows when building the UPN PAC structure
  • CLIENT_INFO should be the same timestamp as the outer kerberos authtime. Make sure of that when resigning, else there might be an error related to "message integrity"

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.46%. Comparing base (fbd0956) to head (5bba0c7).

Files with missing lines Patch % Lines
scapy/layers/ntlm.py 10.00% 9 Missing ⚠️
scapy/modules/ticketer.py 0.00% 7 Missing ⚠️
scapy/layers/msrpce/mspac.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fbd0956) and HEAD (5bba0c7). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (fbd0956) HEAD (5bba0c7)
12 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5027       +/-   ##
===========================================
- Coverage   80.34%   47.46%   -32.88%     
===========================================
  Files         386      368       -18     
  Lines       96034    95672      -362     
===========================================
- Hits        77154    45411    -31743     
- Misses      18880    50261    +31381     
Files with missing lines Coverage Δ
scapy/layers/msrpce/mspac.py 0.00% <0.00%> (-90.79%) ⬇️
scapy/modules/ticketer.py 0.00% <0.00%> (-46.02%) ⬇️
scapy/layers/ntlm.py 25.00% <10.00%> (-56.38%) ⬇️

... and 336 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant