Skip to content

Update RSVP module with a new SESSION object, docstrings, & tests#5026

Open
Dizarc wants to merge 6 commits into
secdev:masterfrom
Dizarc:dizarc/update-rsvp
Open

Update RSVP module with a new SESSION object, docstrings, & tests#5026
Dizarc wants to merge 6 commits into
secdev:masterfrom
Dizarc:dizarc/update-rsvp

Conversation

@Dizarc

@Dizarc Dizarc commented Jun 28, 2026

Copy link
Copy Markdown

Description

  • Added RSVP SESSION object as per RFC 3209.
  • Added docstrings to all the classes/functions inside the RSVP module.
  • Expanded Master dissection test to include more objects.
  • Created new test for SESSION object.
  • Updated two BitFields to IntFields for clarity.

@Dizarc Dizarc changed the title Dizarc/update rsvp Update RSVP module with a new SESSION object, docstrings, & tests Jun 28, 2026
@Dizarc Dizarc force-pushed the dizarc/update-rsvp branch from 74046df to 995b559 Compare June 28, 2026 18:23
@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.33%. Comparing base (fbd0956) to head (995b559).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5026      +/-   ##
==========================================
- Coverage   80.34%   80.33%   -0.01%     
==========================================
  Files         386      386              
  Lines       96034    96043       +9     
==========================================
- Hits        77154    77153       -1     
- Misses      18880    18890      +10     
Files with missing lines Coverage Δ
scapy/contrib/rsvp.py 93.90% <100.00%> (+0.75%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@polybassa

Copy link
Copy Markdown
Contributor

Thanks for the PR, could you please reduce the amount of docstrings to a minimum, since we want to keep the number of changes low, if possible.

Comment thread scapy/contrib/rsvp.py Outdated
Comment thread scapy/contrib/rsvp.py
Comment thread scapy/contrib/rsvp.py Outdated
@Dizarc Dizarc force-pushed the dizarc/update-rsvp branch from 7e3dd05 to e2fae0b Compare June 29, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants