Repository navigation
feat(database): use Desktop host configuration for currency display - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both source workspaces now use published Desktop SDK 0.1.24 and one in-memory HostConfig request for currency display and subscription state, with shellCoin fallback for missing currency or failed requests.
This removes duplicated SDK workspaces and legacy currency configuration, preserves supported v5.1 quota kinds, and adds regression coverage and upgrade documentation.
Upgrade
Upgrade Desktop first for CNY/USD and remove
database.ui.currencySymbolfrom manually mounted main configuration before startup, as the strict schema rejects the obsolete field.Validation
Passed: 16 HostConfig tests, 4 deployment compatibility tests including Helm rendering, both workspace typechecks, both Helm lints, and commit-time secret scanning; embedded Desktop integration remains untested.
Sequence Diagram
sequenceDiagram participant App as Database app participant Store as Shared HostConfig store participant SDK as Desktop SDK 0.1.24 participant Desktop as Sealos Desktop participant UI as Price and quota UI App->>SDK: Initialize App->>Store: Load host configuration once Store->>SDK: getHostConfig() SDK->>Desktop: Request host configuration alt Host configuration received Desktop-->>Store: Currency and subscription via SDK Store->>Store: Use shellCoin when currency is absent else Request fails Store->>Store: Default to shellCoin and subscription enabled end Store-->>UI: Shared currency and subscription state