Add improved sigint handling for cancellation#33
Closed
midnightveil wants to merge 1 commit intoseL4:masterfrom
Closed
Add improved sigint handling for cancellation#33midnightveil wants to merge 1 commit intoseL4:masterfrom
midnightveil wants to merge 1 commit intoseL4:masterfrom
Conversation
Actually propagate upwards the SIGINT as the cause of the failure. Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
Contributor
Author
|
Requesting a review from @wom-bat. |
midnightveil
commented
Apr 23, 2026
| # https://github.com/openssh/openssh-portable/blob/V_10_0_P1/mux.c#L2057-L2059 | ||
| # (However, sometimes it will instead forward through status 130 from the process | ||
| # which received SIGINT on the other end of the SSH session. Sometimes...) | ||
| if [ "${ret}" == "255" ]; then |
Contributor
Author
There was a problem hiding this comment.
OK, so this doesn't seem to be reliable.
Our console scripts in /tftpboot will return -1 if various subcommands fail, which results in sys.exit(-1) which terminates python with code 255.
This seems like it would be a bad idea.
I'm going to go with Indan's suggestion: seL4/ci-actions#461 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually propagate upwards the SIGINT as the cause of the failure.