CI: skip 32-bit Windows wheel builds#916
Open
mykaul wants to merge 1 commit into
Open
Conversation
The *i686 skip pattern in cibuildwheel config matches only Linux 32-bit identifiers (e.g. cp310-manylinux_i686), not Windows 32-bit (which uses win32, e.g. cp310-win32). Add *win32 to skip 32-bit Windows builds, which fail because: - c_shard_info.c uses __uint128_t (GCC extension, unsupported by MSVC) - cryptography test dependency fails to build for i686-pc-windows-msvc due to missing OpenSSL
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Is it a fix for #906 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
*i686skip pattern in cibuildwheel config only matches Linux 32-bit identifiers (e.g.cp310-manylinux_i686), not Windows 32-bit which useswin32(e.g.cp310-win32). Add*win32to skip 32-bit Windows builds, which fail because:c_shard_info.cuses__uint128_t(GCC extension, unsupported by MSVC)cryptographytest dependency fails to build fori686-pc-windows-msvcdue to missing OpenSSL