Warn and render na_color when color column is all-NaN#637
Merged
Conversation
Previously an all-NaN color column raised a misleading ValueError that blamed instance-id alignment even when the join succeeded. Now: - if dtypes differ (genuine alignment failure) the error is kept but rephrased to drop the incorrect "could not be aligned" language - if dtypes match (all-NaN column) a warning is emitted and every element is rendered with na_color, consistent with partial-NaN behaviour Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the dtype_hint gate that could silently swallow genuine alignment failures when _build_alignment_dtype_hint returns "" for reasons other than matching dtypes. Instead always warn and render with na_color, appending the dtype hint to the message when present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 76.40% 76.33% -0.08%
==========================================
Files 11 11
Lines 3230 3232 +2
Branches 758 758
==========================================
- Hits 2468 2467 -1
- Misses 464 466 +2
- Partials 298 299 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #599.
Summary
ValueErrorblaming instance-id alignment even when the join succeededna_color, consistent with partial-NaN behaviour