Conversation
…ort to render_labels The guard in _render_shapes was `if values_are_categorical` instead of `if not values_are_categorical`, causing transfunc to be silently ignored for continuous data and to crash with a TypeError for categorical data. render_labels had no transfunc support at all. Added the field to LabelsRenderParams, wired it through basic.py, and applied the same guard already present in _render_points. Fixes #596. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bels Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
+ Coverage 76.32% 76.37% +0.05%
==========================================
Files 11 11
Lines 3227 3230 +3
Branches 757 758 +1
==========================================
+ Hits 2463 2467 +4
+ Misses 465 464 -1
Partials 299 299
🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_render_shapeshad an inverted condition:if values_are_categoricalinstead ofif not values_are_categorical, sotransfuncwas silently ignored for continuous data and crashed withTypeErrorfor categorical datarender_labelshad notransfuncsupport at all — added the field toLabelsRenderParams, wired it throughbasic.py, and applied the same guard already present in_render_pointsFixes #596.