Repository navigation
fix!: use the probed threading layer to detect unsafe threads - #218
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 99.32% 99.31% -0.02%
==========================================
Files 21 21
Lines 597 584 -13
==========================================
- Hits 593 580 -13
Misses 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 48.3%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| 👁 | test_stats_benchmark[scipy.sparse.csr_array-2d-ax1-int32-is_constant] |
299.9 ms | 530.5 ms | -43.46% |
| 👁 | test_stats_benchmark[scipy.sparse.csc_array-2d-ax0-int32-is_constant] |
306 ms | 647.2 ms | -52.73% |
Comparing selmanozleyen:threading-layer-probe (5d7e342) with main (0486005)
selmanozleyen
force-pushed
the
threading-layer-probe
branch
from
September 24, 2026 12:40
d7e97a5 to
5a39588
Compare
flying-sheep
left a comment
Member
There was a problem hiding this comment.
You say this fixes #215 – does that mean we can delete code replicating numba’s layer selection?
flying-sheep
requested changes
Sep 25, 2026
flying-sheep
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #215