Skip to content

fix!: use the probed threading layer to detect unsafe threads - #218

Merged
flying-sheep merged 3 commits into
scverse:mainfrom
selmanozleyen:threading-layer-probe
Sep 25, 2026
Merged

flying-sheep merged 3 commits into
scverse:mainfrom
selmanozleyen:threading-layer-probe

Conversation

@selmanozleyen

Copy link
Copy Markdown
Member

fixes: #215

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (0486005) to head (5d7e342).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   99.32%   99.31%   -0.02%     
==========================================
  Files          21       21              
  Lines         597      584      -13     
==========================================
- Hits          593      580      -13     
  Misses          4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 48.3%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 (👁 2) regressed benchmarks
✅ 230 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
👁 test_stats_benchmark[scipy.sparse.csr_array-2d-ax1-int32-is_constant] 299.9 ms 530.5 ms -43.46%
👁 test_stats_benchmark[scipy.sparse.csc_array-2d-ax0-int32-is_constant] 306 ms 647.2 ms -52.73%

Comparing selmanozleyen:threading-layer-probe (5d7e342) with main (0486005)

Open in CodSpeed

@flying-sheep flying-sheep left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You say this fixes #215 – does that mean we can delete code replicating numba’s layer selection?

Comment thread src/fast_array_utils/numba/_parallel_runtime.py Outdated
@selmanozleyen selmanozleyen changed the title fix: use the probed threading layer to detect unsafe threads fix! use the probed threading layer to detect unsafe threads Sep 24, 2026
@selmanozleyen selmanozleyen changed the title fix! use the probed threading layer to detect unsafe threads fix!: use the probed threading layer to detect unsafe threads Sep 24, 2026
@flying-sheep flying-sheep added the run-gpu-ci Apply this label to run GPU CI once label Sep 25, 2026
@flying-sheep
flying-sheep merged commit 83974b6 into scverse:main Sep 25, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-gpu-ci Apply this label to run GPU CI once

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why does fau need to know about numba internals for thread layer

2 participants