refactor(zkvm): canonicalize PI transcript/opening flow via instance_value + PublicValues#1277
Merged
Conversation
Replace raw public-input transcript absorption with circuit-driven instance_value indexing in prover, native verifier, and recursion verifier. Also add instance_value tracking in ConstraintSystem::query_instance and fix mutability/borrow fallout in public-value query helpers and RAM table address setup.
hero78119
force-pushed
the
feat/pi_observe
branch
from
313fbf3 to
d00c2aa
Compare
hero78119
force-pushed
the
feat/pi_observe
branch
from
d00c2aa to
7099d2c
Compare
hero78119
changed the title
This PR migrates public input/output handling from raw public-io memory openings to a digest-based path and unifies PI plumbing across prover/verifier/recursion. ## Design rationales - Avoids carrying vector-style public-io MLE openings through proving/verifying paths. - Reduces PI plumbing complexity and duplicated logic between native verifier and recursion verifier. - Makes public output commitment explicit and uniform via digest commitments. ## Changes Highlights - Commit public IO as a Keccak-256 digest (8 x u32 words) instead of opening raw public-io MLE columns. - Add runtime commit APIs in `ceno_rt`: - `commit(data: &[u8])` - `commit_digest([u32; 8])` - `CommitCtx` for incremental accumulation + finalize. - Add `PUB_IO_COMMIT` syscall support end-to-end: - emulator syscall implementation in `ceno_emul/src/syscalls/pubio_commit.rs` - zkVM ecall instruction in `ceno_zkvm/src/instructions/riscv/ecall/pubio_commit.rs` - RV32IM wiring and dispatch updates. - Introduce digest limb layout/query path: - `PUBIO_DIGEST_IDX`, `PUBIO_DIGEST_U16_LIMBS` - `query_public_io_digest()` and `PubioCommitLayout`. - Simplify PI representation: - `ProofInput.pi` replaces `pub_io_evals`/public-input MLE plumbing - remove `pi_in_evals`, `instance_openings`, `raw_pi_num_variables`, and related split/eval paths. - Update recursion verifier/binding to consume scalar PI directly and keep transcript order aligned with native verifier. - Remove legacy public-io memory region usage from platform/linker init flow (no preloaded pubio segment).
hero78119
force-pushed
the
feat/pi_observe
branch
from
1ee30c3 to
ca0426f
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how public inputs (PI) are represented and consumed across zkVM proving/verification so that PI handling is circuit-driven and consistent end-to-end.
Related to #1263.
Design rationale
Previously, PI transcript absorption and some verifier checks depended on broader/raw PI containers, which made ordering and indexing assumptions harder to audit and keep consistent across:
This PR moves PI consumption to a canonical, circuit-defined path:
instance_valuesdefines which scalar PI values a circuit observes (and in what order).instance_openingsdefines which PI MLE columns are opened.PublicValuesMLEs, rather than ad-hoc/raw vectors.This reduces ambiguity in PI ordering/indexing and aligns transcript-visible PI handling with circuit semantics.
pi update
Previous
pi_updatemechanism will trigger verifier failed if a identical public value used > 1 chip because they will be in different opening point, thus evaluation value will be different. This PR fixed the issue, and refactor public value check back toverify_chip_phasesoundness fix
This PR also fixed a soundness issue by removing
wit_in_evalsandfixed_in_evalsfrom the proof payload. Instead of trusting prover-supplied values for these evaluations, the verifier now deterministically derives them from the sumcheck evaluations during verification. This prevents a malicious prover from introducing mismatches between claimed eval vectors and the actual sumcheck-consistent values.Follow up
#1280