Skip to content

feat: align LanguageSettingsScreen header and layout order with Figma designs - #675

Merged
andrewtavis merged 1 commit into
scribe-org:mainfrom
prince-0408:feature/align-language-settings-figma-674
Aug 19, 2026
Merged

feat: align LanguageSettingsScreen header and layout order with Figma designs #675
andrewtavis merged 1 commit into
scribe-org:mainfrom
prince-0408:feature/align-language-settings-figma-674

Conversation

@prince-0408

Copy link
Copy Markdown
Collaborator

Description

This PR addresses issue #674 by aligning the LanguageSettingsScreen UI layout and header title with the official Figma designs.

Key Improvements:

  • Header Title Formatting: Updated the top page header title format from {Language} (e.g. English) to {Language} settings (e.g., Deutsch settings, English settings) as specified in the Figma design system.
  • Layout Section Item Reordering: Re-ordered the list items under the Layout section in getLayoutListData() to match the exact Figma visual hierarchy:
    1. Default keyboard (Default layout)
    2. Default currency symbol
    3. Period and comma on ABC
    4. Disable accent characters (conditionally displayed for German, Swedish, and Spanish)
  • Extensible Navigation Callback: Introduced an optional onDefaultLayoutSelect callback parameter to LanguageSettingsScreen for seamless future navigation handling.

Related Issue

Closes #674


Changes Made

File / Location Summary of Changes
app/src/main/java/be/scri/ui/screens/LanguageSettingsScreen.kt • Updated pageTitle calculation to render "{Language} settings".
• Added Default keyboard (R.string.i18n_app_settings_keyboard_layout_default_layout) item to getLayoutListData().
• Reordered items in the Layout section to match Figma specs.
• Added optional onDefaultLayoutSelect: () -> Unit = {} callback parameter.

Screenshots & Visual Comparison

Before (Past) After (Current Implementation)
Past Implementation Current Figma Aligned Implementation

Type of Change

  • UI / UX Enhancement (non-breaking visual update matching Figma designs.

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks so much for opening the issue and addressing the layout needs, @prince-0408! This was a great find 😊

@andrewtavis
andrewtavis merged commit 7cc82cc into scribe-org:main Aug 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align LanguageSettingsScreen header and layout order with Figma designs

2 participants