Set HTTP client MaxIdleConns as well - #167
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 75ebc49. Configure here.
Neurostep
force-pushed
the
maksimt/aws-http-client-idle-connections
branch
from
August 3, 2026 09:49
75ebc49 to
460d0bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
In this PR we are setting the HTTP client
MaxIdleConnsas well asMaxIdleConnsPerHost. Previously, the value was only set toMaxIdleConnsPerHostchanging the default value from2to whatever is provided. But overall pool is capped atMaxIdleConnswith the value of100.Checklist
developmentand/orstagingREADME.mdas necessaryRelated links
Note
Low Risk
Small, well-tested change to AWS client HTTP transport tuning; no auth or data-path logic changes.
Overview
Fixes AWS SDK HTTP client pooling so
max_idle_connsactually raises the total idle connection cap, not only per-host.createHttpClientnow setsMaxIdleConnsandMaxIdleConnsPerHostto the configured value when it is > 0; when unset (0), the cloned transport keeps Go’shttp.DefaultTransportlimits instead of overriding only per-host. That removes the case where a value above 100 was effectively capped by the default transport-wideMaxIdleConns.Docs and
HTTPClientcomments describe per-host and total behavior; tests coverMaxIdleConns, a 256 pool, and zero config.Reviewed by Cursor Bugbot for commit 460d0bc. Bugbot is set up for automated code reviews on this repo. Configure here.