[ESSNMX] Update essnmx reduced file for regression test#646
Merged
Conversation
YooSunYoung
commented
Jun 22, 2026
Comment on lines
+191
to
+192
| if 'aux' in dg['entry']: | ||
| del dg['entry']['aux'] |
Member
Author
There was a problem hiding this comment.
It was a bug that needed to be fixed for the documentation.
SimonHeybrock
left a comment
SimonHeybrock
left a comment
Member
There was a problem hiding this comment.
Just a question about docstrings/help.
Comment on lines
+11
to
+17
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument( | ||
| "--freeze-version", | ||
| help="Future version of essnmx that can reproduce the frozen file.", | ||
| required=True, | ||
| ) |
Member
There was a problem hiding this comment.
The description (e.g., inline help) for this script is a bit thin, can it be extended? Unclear when it should be used, and how it related to the test-dataset.ipynb.
SimonHeybrock
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to update the frozen reduced file due to changes in the
tof.I added change log of these files in the developers guide too.
This update should fix the failing nightly(latest) test.