Skip to content

Sort coefficients for placeholder creation #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorgensd merged 1 commit into from
Sep 7, 2026
+3 −1
Merged

Sort coefficients for placeholder creation #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/dolfinx_adjoint/solvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,8 +1020,10 @@ def __init__(
coefficients = collect_coefficients(F) - set(u_list)
if J is not None:
coefficients |= collect_coefficients(J) - set(u_list)
# Has to be sorted when creating placeholders, as function creation is a collective operation
sorted_coefficients = sorted(coefficients, key=lambda c: c.ufl_id())
self._value_placeholders: dict[dolfinx.fem.Function, dolfinx.fem.Function] = {
c: dolfinx.fem.Function(c.function_space) for c in coefficients
c: dolfinx.fem.Function(c.function_space) for c in sorted_coefficients
}

# Initialize nonlinear solver
Expand Down