fix: grant the instance role access to the SSE-C key secret - #1
Merged
Merged
Conversation
The sidecar reads credential secrets through a Role whose resource names are collected from the credential references. Without the new reference in that list, a key kept in its own secret, as in the docs example, is forbidden and every barman-cloud command fails. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Andrei Nistor <andrei@nistor.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix on top of your
feat/s3-sse-cbranch (cloudnative-pg#1017), so it lands as part of that PR.The sidecar reads credential Secrets through the per-cluster Role that
BuildRoleRulesassembles fromCollectSecretNamesFromCredentials. The newsseCustomerKeyreference is not in that list, so a key kept in its own Secret, as in theaws-sse-cexample in the docs, is forbidden to the sidecar and every barman-cloud command fails to resolve credentials. It only works today when the key shares a Secret with the access keys. This adds the reference to the collection, with a test.Sits directly on your branch head (
adb7045), nothing else pulled in.One observation while testing against an S3 provider that only offers SSE-C: the branch is based on v0.14.0, whose sidecar pins Barman 3.19.1, and
--sse-customer-keyexists from 3.20.0, whichmainpins since v0.15.0. A rebase ontomainis needed before the feature can work end to end.