Skip to content

chore(deps): update scality/workflows action to v2.12.1 - #68

Merged
g-carre merged 1 commit into
mainfrom
renovate/scality-workflows-2.x
Nov 9, 2026
Merged

g-carre merged 1 commit into
mainfrom
renovate/scality-workflows-2.x

Conversation

@scality-renovate

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
scality/workflows workflow patch v2.12.0 → v2.12.1

Release Notes

scality/workflows

v2.12.1

Compare Source

What's Changed

Full Changelog: scality/workflows@v2.12.0...v2.12.1


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 9am on monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@scality-renovate
scality-renovate Bot requested a review from a team as a code owner November 9, 2026 03:25
@scality-renovate scality-renovate Bot added automerge-candidate ci dependencies Dependency updates, opened by Renovate patch labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Dependency Bump Evaluation

Version change: scality/workflows v2.12.0 -> v2.12.1 (pinned SHA 91619d8, which matches the upstream v2.12.1 tag)
Semver bump type: patch

Changes:

  • Upstream diff touches only claude-code-review.yml (fix(claude-code-review): use the job token instead of the OIDC app token exchange workflows#114). promote.yaml, release.yaml and claude-code-dependency-review.yml are unchanged, so the bumps in promote.yaml, release.yaml and the review-dependency-bump job change nothing.
  • claude-code-action now gets github_token: ${{ github.token }} instead of using the OIDC -> GitHub App token exchange. Since 2026-10-30 that exchange has been returning 401 for checks: write, and because the step is continue-on-error the review was silently not posted.
  • additional_permissions is removed.
  • A new first step fails the job when it runs on pull_request_target.

Breaking changes: None for this repo. The new pull_request_target guard cannot fire here: the review job in .github/workflows/review.yaml already only runs when github.event_name == 'pull_request'.

Security concerns: This changes how the review job gets its GitHub token, which is credential handling, so it is flagged for human review. The change itself looks like a hardening: the job now uses its own GITHUB_TOKEN, limited to the permissions it declares (checks: write, contents: read, pull-requests: write), and it refuses to run on pull_request_target. The commits are by a Scality maintainer, and no new third-party actions or dependencies are added.

Impact on codebase: Only .github/workflows/review.yaml (the review job) is affected. It should start posting Claude code reviews again. No changes needed in the caller workflow.

Recommendation: REVIEW REQUIRED

Notes: This is a low-risk patch. It is not auto-approved for two reasons: it changes GitHub token handling, and the PR is authored by scality-renovate[bot], not dependabot. CI checks (agent-ci, rpm-ci) were still running when this was evaluated. Merge once they are green.

— Claude Code

@g-carre
g-carre merged commit beaf9c9 into main Nov 9, 2026
18 checks passed
@g-carre
g-carre deleted the renovate/scality-workflows-2.x branch November 9, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-candidate ci dependencies Dependency updates, opened by Renovate patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant