Raise Node floor to 22, test on 24 - #48
Merged
Merged
Conversation
Node 20 reached end of life in April 2026, so the manifest was advertising support for a runtime nobody tests. This has no functional effect today, it just stops the package claiming a dead runtime. Deliberately >=22 and not >=24: Arsenal and backbeat consume this library and are still on 22, so raising it that far now would break their installs. It can drop to >=24 once they have moved. Issue: ARSN-642
The lockfile had drifted well behind: js-yaml, flatted, brace-expansion and @humanfs/node were all held at versions with published advisories, three of them high severity. Every fix was already inside the ranges we declare, so this is lockfile-only and pulls in no new majors. The markdown-it and linkify-it advisories that remain come from exact pins inside eslint-config-scality and can only be fixed there. Issue: ARSN-642
Issue: ARSN-642
francoisferrand
requested review from
a team,
DarkIsDude,
anurag4DSB,
delthas,
jonathan-gramain and
tcarmet
and removed request for
a team
September 16, 2026 17:58
jonathan-gramain
approved these changes
Sep 16, 2026
DarkIsDude
approved these changes
Sep 17, 2026
delthas
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 20 went EOL in April 2026, so
engines.node: ">=20"was advertising a runtime nobody tests. No functional effect — everything we run on already satisfies>=20— it just stops the manifest claiming a dead runtime.Deliberately
>=22and not>=24: Arsenal and backbeat consume this library and are still on 22, so going straight to 24 would break their installs. It can drop to>=24once they've moved, or when 22 goes EOL in April 2027.CI now runs a 22/24 matrix instead of a single pinned 22, so we're actually testing the runtime we're heading for.
While in here I refreshed
yarn.lock, which had drifted a long way behind — js-yaml, brace-expansion, flatted and @humanfs/node were all held at versions with published advisories, three of them high. Every fix was already inside the ranges we declare, so it's lockfile-only and pulls in no new majors. Takes the audit from 10 findings down to 3.The remaining 3 can't be fixed here. The
eslint-config-scality"malware" critical is a false positive: we resolve it from GitHub overgit+, not from the registry where the name is squatted.markdown-itandlinkify-itcome from exact pins inside Guidelines and need fixing there.Going out as 1.1.1 rather than 1.2.0 — no runtime source has changed since 1.1.0, consumers pin by git ref so nothing auto-resolves, and the
agentkeepaliverange bump resolves to the same version either way.Issue: ARSN-642